Skip to content

deps: bump k8s to v1.20 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

deps: bump k8s to v1.20 #140

wants to merge 1 commit into from

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Dec 15, 2020

Follows up on #139.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: estroz
To complete the pull request process, please assign monopole after the PR has been reviewed.
You can assign the PR to them by writing /assign @monopole in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Dec 15, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 15, 2020
@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@estroz estroz marked this pull request as ready for review January 13, 2021 16:11
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 13, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 13, 2021
@estroz
Copy link
Contributor Author

estroz commented Jan 13, 2021

@atoato88 can you review/approve this again?

@atoato88
Copy link
Contributor

/lgtm
@estroz
Thank you to update & mention to me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@estroz
Copy link
Contributor Author

estroz commented Jan 14, 2021 •
edited
Loading

@atoato88 np! Can you /approve this as well, or are you waiting for another to approve? If so, I can assign someone else. Nevermind, looks like you are not an approver. I will assign someone else.

@estroz
Copy link
Contributor Author

estroz commented Jan 14, 2021

/assign @monopole

@atoato88
Copy link
Contributor

Thank you to quick response. 😄
Should I become approver in this repo.. 🤔

@estroz
Copy link
Contributor Author

estroz commented Jan 18, 2021

Closing in favor of #146

/close

@k8s-ci-robot
Copy link
Contributor

@estroz: Closed this PR.

In response to this:

Closing in favor of #146

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 Awaiting requested review from atoato88

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@atoato88 atoato88

@monopole monopole

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estroz @k8s-ci-robot @atoato88 @monopole