Skip to content

Add template for issue and PR #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

atoato88
Copy link
Contributor

This PR add template files for issue and PR on GitHub.
It's good to clarify information about issue and PR.

I referred k/k's templates for issue and PR.
But that is too much input items for this repository I think, I cut some items from it for ease to input.

This commit add template files for issue and PR on GitHub.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2021
@atoato88
Copy link
Contributor Author

/assign @justinsb

@justinsb
Copy link
Contributor

It's probably a lot of information for a library (vs something directly user facing), but I ❤️ the idea and we can always trim it down later if we need to!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2021
@justinsb
Copy link
Contributor

/retest

Test failure was unrelated, should have been fixed by #155

@k8s-ci-robot k8s-ci-robot merged commit d1606a7 into kubernetes-sigs:master Mar 22, 2021
@atoato88
Copy link
Contributor Author

@justinsb
Thank you for approving.

... we can always trim it down later if we need to!

Yes, I agree with your idea. We can always fit the template to our usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants