Skip to content

Embed Applier interface in kubectlClient interface #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Embed Applier interface in kubectlClient interface #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/patterns/declarative/pkg/applier/type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ import (
)

type Applier interface {
Applyx(ctx context.Context, namespace string, manifest string, validate bool, extraArgs ...string) error
Apply(ctx context.Context, namespace string, manifest string, validate bool, extraArgs ...string) error
}
2 changes: 1 addition & 1 deletion pkg/patterns/declarative/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type Reconciler struct {
}

type kubectlClient interface {
Apply(ctx context.Context, namespace string, manifest string, validate bool, args ...string) error
applier.Applier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. I do wonder if there's any reason to keep the kubectlClient interface, if we have the exported applier.Applier interface...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with your comment, we can use Applier interface instead of kubectlClient interface.

}

type DeclarativeObject interface {
Expand Down