-
Notifications
You must be signed in to change notification settings - Fork 83
Add unit tests for sort.go #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a part of #150 : More unit tests are needed. |
As of now, this PR doesn't pass test, because of item to be fixed. |
/assign @justinsb |
/retest |
6ec9c69
to
ec386dc
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: atoato88 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
09a25f5
to
044be6b
Compare
This commit add unit tests for sort.go
044be6b
to
72da8c0
Compare
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
@atoato88: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@atoato88 Is this still active? or will we need to drop? |
@oomichi This PR is pretty old and not active. |
Said as above comment, I close PR. |
This PR add unit tests for
sort.go
.In making this PR, I found a item should be fixed about decision of Secret because it's
/Secrets
not/Secret
.I'll create another PR, soon.