Skip to content

Add unit tests for sort.go #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

atoato88
Copy link
Contributor

This PR add unit tests for sort.go.

In making this PR, I found a item should be fixed about decision of Secret because it's /Secrets not /Secret.
I'll create another PR, soon.

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 16, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2021
@atoato88
Copy link
Contributor Author

This is a part of #150 : More unit tests are needed.

@atoato88
Copy link
Contributor Author

atoato88 commented Feb 16, 2021

As of now, this PR doesn't pass test, because of item to be fixed.
#153 will fix that.

@atoato88
Copy link
Contributor Author

/assign @justinsb

@atoato88
Copy link
Contributor Author

/retest

@atoato88 atoato88 force-pushed the add-unit-test-sort-go branch from 6ec9c69 to ec386dc Compare March 23, 2021 10:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atoato88
To complete the pull request process, please ask for approval from justinsb after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atoato88 atoato88 force-pushed the add-unit-test-sort-go branch 2 times, most recently from 09a25f5 to 044be6b Compare March 23, 2021 10:36
This commit add unit tests for sort.go
@atoato88 atoato88 force-pushed the add-unit-test-sort-go branch from 044be6b to 72da8c0 Compare March 23, 2021 10:47
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2021
@k8s-ci-robot
Copy link
Contributor

@atoato88: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2021
@oomichi
Copy link

oomichi commented Jul 16, 2021

@atoato88 Is this still active? or will we need to drop?

@atoato88
Copy link
Contributor Author

@oomichi This PR is pretty old and not active.
I'll close this PR.

@atoato88
Copy link
Contributor Author

Said as above comment, I close PR.

@atoato88 atoato88 closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants