Skip to content

Explicitly set update_policy on GCE instance group managers #17411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

flopib
Copy link
Contributor

@flopib flopib commented May 20, 2025

Fixes #17382.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @flopib. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label May 20, 2025
@k8s-ci-robot k8s-ci-robot requested review from hakman and johngmyers May 20, 2025 17:28
@hakman
Copy link
Member

hakman commented May 23, 2025

/ok-to-test
/cc @justinsb
/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 23, 2025
@k8s-ci-robot k8s-ci-robot requested a review from justinsb May 23, 2025 09:59
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 23, 2025
@flopib flopib force-pushed the gce-tf-update-policy branch from c127a90 to b43c9cb Compare May 23, 2025 11:23
@hakman
Copy link
Member

hakman commented May 23, 2025

/retest

@flopib
Copy link
Contributor Author

flopib commented Jun 11, 2025

Hi, would it be possible to review this shortly? Our customer is still susceptible of being affected by the linked issue.

@flopib flopib requested a review from rifelpet June 12, 2025 08:02
Co-authored-by: Peter Rifel <[email protected]>
@flopib flopib requested a review from rifelpet June 12, 2025 14:16
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1c518ec into kubernetes:master Jun 12, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform GCE should set groups update_policy
5 participants