perl-for-cntrl-chars #34
Conversation
kubectl-node_shell
Outdated
| @@ -75,7 +75,7 @@ done | |||
| if [ $# -gt 0 ]; then | |||
| while [ $# -gt 0 ]; do | |||
| cmd="$cmd, \"$(echo "$1" | \ | |||
| awk '{gsub(/\\/,"\\\\");gsub(/"/,"\\\"");gsub(/$/,"\\n");printf last}{last=$0} END{gsub(/\\n/,"",last);printf last}' \ | |||
| perl -pl -0777 -e 's/([\\"])/\\$1/g;s/\n$//;s/\n/\\n/g;s/([\x01-\x1f])/sprintf "\\u%04x",ord $1/ge' \ | |||
There was a problem hiding this comment.
Unfortunately perl is not installed on many systems by default, let's try using as less dependencies as we can.
Awk was a nice solution, and persist almost everywhere, so why not using it?
There was a problem hiding this comment.
Because it doesn't handle control-characters like 0x1b, which I need? https://datatracker.ietf.org/doc/html/rfc7159#section-7
There was a problem hiding this comment.
Exactly which systems have kubectl installed, but not perl? Windows?
There was a problem hiding this comment.
Many of them, even linux distros: for example centos, alpine linux, archlinux have no it out of box.
joesuf4
force-pushed
the
perl
branch
3 times, most recently
from
4a51f3a to
3ae2b92
Compare
|
If you want to implement most of the JSON spec faithfully, as it relates to the bulk of 7-bit ascii, you need to use something with more power than awk. If you just want to support my use case, and stick to awk, that's also fine with me. This MR has that developed in the final commit. |
|
This become to be a madness. I committed please rebase your PR and run |
|
All tests pass. Should be good to go now. Thanks for the test suite! |
|
@joesuf4 thanks! Could you also add the test case you solving by this change? |
|
Done. |
|
Perfect, thank you for contribution! |
No description provided.