added secretBase64Encoded parameter to the decode func. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Thinking about this API some more, it shouldn't actually take a String but instead Data. You can then pass in Data which can be created from a String of a base64 string. .hs256("secret".data(using: .utf8)!).hs256(Data(base64Encoded: "c2VjcmV0")!)This behaviour is now supported in JSONWebToken 2.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JWT-Secrets which are base64 encoded (for example from Auth0) couldn't be decoded and verified before.
There's an additional checkbox in https://jwt.io to mark the secret as base64 encoded.
Therefore I added a flag to mark the secret as base64 encoded, so the sign-function could handle the secret.