Payload and general swift improvements #45
Conversation
siemensikkema
commented
Sep 28, 2016
siemensikkema
commented
- merges PayloadBuilder and Payload
- add type safe access to Payload properties
- use guard syntax where applicable
- use Swift error handling instead of returning optional InvalidTokens
- rename Test classes
- simplified Date verification error handling
- consistent colon/space syntax
- merges PayloadBuilder and Payload - add type safe access to Payload properties - use guard syntax where applicable - use Swift error handling instead of returning optional InvalidTokens - rename Test classes - simplified Date verification error handling - consistent colon/space syntax
It took unexpected precedence over explicit types, eg when setting a value of type Date and it is unsafe.
|
Thanks for the pull request @siemensikkema. I'm a little busy at the moment but I'll try and review these changes in the next few days. |
|
Sorry for the delay on this one @siemensikkema. Would you be able to update the README examples to still work with your changes please. |
|
@siemensikkema It would be great if this could get merged in! 🎉 Do you need help with finishing up the README as @kylef mentioned? :) |
|
Thanks again for this pull request @siemensikkema, I've manually merged most of these changes in but I've made some changes:
See ce7285f for documentation / CHANGELOG changes describing. |
|
Looks good! I wanted to respond and help you with the changes but I hadn't yet found the time. I think ClaimSet is a great name although it is possible and useful to include other information there that are not strictly claims. |
