-
Notifications
You must be signed in to change notification settings - Fork 224
Implement leeway for date validation #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement leeway for date validation #83
Conversation
@kylef do you have any clue why |
I do not think
|
Any clue why Travis is complaining? It says it can't find the build logs for macOS.. |
@kylef checks are through. If you agree with my implementation it would be great to have the PR accepted 👍 |
I think this is good, I'll give it a review soon and make a release incorporating these changes. Can you add an entry in |
Might be good to add a note about this in the |
|
Awesome, nice work here @JanBrinker. I appreciate the pull request. |
@kylef I implemented the
leeway
as discussed by optional function parameters. This way there are no code breakages.I also added unit tests for each date validation (both cases: fail without leeway and success with leeway) and added two small integration tests to check whether the leeway is passed through all calls down to the validators.