Skip to content

fix: config name isn't always a base config #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2024
Merged

fix: config name isn't always a base config #1047

merged 4 commits into from
Apr 29, 2024

Conversation

MegaRedHand
Copy link
Collaborator

The field CONFIG_NAME doesn't always refer to an existing base config. In those cases, we should just ignore it.

@MegaRedHand MegaRedHand self-assigned this Apr 26, 2024
@MegaRedHand MegaRedHand requested a review from a team as a code owner April 26, 2024 13:29
@MegaRedHand MegaRedHand merged commit 2a0ad72 into main Apr 29, 2024
@MegaRedHand MegaRedHand deleted the fix-config-name-not-base-config branch April 29, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

Assignees

@MegaRedHand MegaRedHand

Labels
None yet
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MegaRedHand @mpaulucci