Skip to content

fix: make sure to flush the logger before halting. #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

mpaulucci
Copy link
Collaborator

Motivation
The application was crashing but I wasn't seen any log before. This fixes it

@mpaulucci mpaulucci requested a review from a team as a code owner April 26, 2024 16:59
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mpaulucci mpaulucci enabled auto-merge (squash) April 26, 2024 17:06
@mpaulucci mpaulucci merged commit b5f8fbb into main Apr 26, 2024
@mpaulucci mpaulucci deleted the flush-before-halt branch April 26, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants