Skip to content

refactor: move BLS and KZG specific types to their specific modules #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

guha-rahul
Copy link
Contributor

Motivation

Description

Closes #849

@guha-rahul guha-rahul requested a review from a team as a code owner April 27, 2024 12:49
@guha-rahul guha-rahul changed the title moved types to bls.ex and kzg.ex Move BLS and KZG specific types to their specific modules Apr 27, 2024
@guha-rahul guha-rahul changed the title Move BLS and KZG specific types to their specific modules move BLS and KZG specific types to their specific modules Apr 27, 2024
@guha-rahul guha-rahul changed the title move BLS and KZG specific types to their specific modules refactor: move BLS and KZG specific types to their specific modules Apr 27, 2024
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@guha-rahul guha-rahul requested a review from MegaRedHand April 28, 2024 18:09
@guha-rahul
Copy link
Contributor Author

guha-rahul commented Apr 29, 2024

@MegaRedHand hey i forgot to the update the typespaces in other files , but even after replacing them , I am getting the dialyzer error.

Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@MegaRedHand MegaRedHand enabled auto-merge (squash) April 29, 2024 20:12
@MegaRedHand MegaRedHand disabled auto-merge April 29, 2024 20:12
@MegaRedHand MegaRedHand enabled auto-merge (squash) April 29, 2024 20:13
@guha-rahul
Copy link
Contributor Author

Thank you for helping out!

@MegaRedHand MegaRedHand merged commit 3342290 into lambdaclass:main Apr 29, 2024
@guha-rahul guha-rahul deleted the move-bls-and-kzg-specific-types-to-their-specific-modules branch May 1, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Move BLS and KZG specific types to their specific modules
2 participants