feat: derive Keystore public key from secret key #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guha-rahul
changed the title
MegaRedHand
reviewed
May 15, 2024
|
hey @MegaRedHand sorry for the late pr. But i have fixed the issue , let me know if you need any changes. |
MegaRedHand
reviewed
May 19, 2024
|
Thank you and add the necessary changes. Not sure why the 2nd commit happened. |
MegaRedHand
reviewed
May 20, 2024
|
added the fix. |
MegaRedHand
approved these changes
May 20, 2024
|
Thank you @MegaRedHand , for helping me out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
addresses #1028
Having an error in deserialization. deserialization accepts u8 but private key is of type Binary. In other functions it works fine.
Wondering where I went wrong.