Skip to content

fix: endpoint not available on GET /health #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

avilagaston9
Copy link
Contributor

Motivation

We had an error when calling GET /health the first couple of times.

Description

Just change the order of how the app supervisor children are initialized.

Closes #1094

@avilagaston9 avilagaston9 marked this pull request as ready for review May 24, 2024 18:02
@avilagaston9 avilagaston9 requested a review from a team as a code owner May 24, 2024 18:02
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right way, as we should probably bring up the endpoint after the node is available, but there's probably a non-trivial race condition there, so I'm ok with this for now.

@Arkenan Arkenan enabled auto-merge (squash) May 28, 2024 13:46
@Arkenan Arkenan merged commit 2789b16 into main May 28, 2024
13 checks passed
@Arkenan Arkenan deleted the endpoint_persistent_term branch May 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Endpoint persistent term not available when calling /health the first couple of times
2 participants