refactor: remove GenServer behavior from gossip blobsidecar #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avilagaston9
changed the title
avilagaston9
changed the title
Arkenan
requested changes
Jun 6, 2024
| @spec join_topics() :: :ok | ||
| def join_topics() do | ||
| topics() | ||
| |> Enum.each(fn topic_name -> Libp2pPort.join_topic(self(), topic_name) end) |
There was a problem hiding this comment.
We should not use each if it can return an error and leave the node in an unusable state. We should be able to return an error here, for example, with a reduce, or with a map and then counting the errors.
Arkenan
approved these changes
Jun 7, 2024
Comment on lines
33
to
34
| Libp2pPort.subscribe_to_topic(topic, __MODULE__) | ||
| |> case do |
There was a problem hiding this comment.
Let's avoid the pipe for a single operation.
case Libp2pPort.subscribe_to_topic(topic, __MODULE__) do
:ok -> ...
{:error, reason} -> ...
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the GenServer behavior from the gossip BlobSideCar.
Closes #1114