Skip to content

feat: electra consolidations #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 105 commits into from
Apr 24, 2025
Merged

feat: electra consolidations #1428

merged 105 commits into from
Apr 24, 2025

Conversation

LeanSerra
Copy link
Contributor

@LeanSerra LeanSerra commented Apr 14, 2025 •
edited
Loading

Motivation

Implement changes in Electra to deposits + fix all spec-tests related to it.

Description

  • New process_pending_consolidations link
  • Modified process_effective_balance_updates link
  • Modified process_epoch link
    • This PR implements the last modification to the functions process_epoch calls

Fixed Spec Tests

test/generated/mainnet/electra/epoch_processing.exs:
previous: 141 tests, 13 failures
now: 141 tests, 0 failures

test/generated/mainnet/electra/random.exs:
previous: 16 tests, 3 failures
now: 16 tests, 0 failures

test/generated/mainnet/electra/sanity.exs:
previous: 97 tests, 10 failures, 1 skipped
now: 97 tests, 8 failures, 1 skipped

test/generated/minimal/electra/epoch_processing.exs:
previous: 156 tests, 13 failures
now: 156 tests, 0 failures

test/generated/minimal/electra/random.exs:
previous: 16 tests, 2 failures
now: 16 tests, 0 failures

test/generated/minimal/electra/sanity.exs:
previous: 104 tests, 10 failures, 1 skipped
now: 104 tests, 8 failures, 1 skipped

tests fixed: 35

Spec Test Progress

11370 tests, 73 failures, 784 skipped

LeanSerra added 30 commits April 3, 2025 11:21
@LeanSerra
feat EpochProcessing.process_slashings electra changes
ed74379
@LeanSerra
feat compute_proposer_index changes
71b3674
@LeanSerra
feat compute_sync_committees Electra changes
9aa4202
@LeanSerra
fix fork_choice.ex tests were flaky because env var cleanup was not done
f09b71b 
in fails
@LeanSerra
feat eligible_for_activation_queue Electra changes
df45ee4
@LeanSerra
feat new compounding_withdrawal_credential? Electra function
8fb4d63
@LeanSerra
feat new has_compounding_withdrawal_credential Electra function
6e34108
@LeanSerra
feat new has_execution_withdrawal_credential Electra function
620e700
@LeanSerra
feat fully_withdrawable_validator? Electra changes
d904593
@LeanSerra
feat new get_max_effective_balance Electra function
5445583
@LeanSerra
feat partially_withdrawable_validator? Electra changes
5cbc5af
@LeanSerra
fix typo in struct field in has_compounding_withdrawal_credential
753badb
@LeanSerra
feat new get_committee_indices Electra function
29bf08a
@LeanSerra
feat get_attesting_indices Electra changes
17bf479
@LeanSerra
lint remove unnecessary parentheses in if
42b0bfb
@LeanSerra
feat slash_validator Electra changes
6df1b36
@LeanSerra
feat new get_balance_churn_limit Electra function
9e13ad5
@LeanSerra
feat new get_activation_exit_churn_limit Electra function
abc2585
@LeanSerra
feat compute_exit_epoch_and_churn Electra function
5b7e5dc
@LeanSerra
feat initiate_validator_exit Electra changes
4eddb4b
@LeanSerra
feat process_registry_updates Electra changes
44a00ec
@LeanSerra
refactor remove unused eject_validator(_,_,_, false) variant
9bc3a0b
@LeanSerra
fix compute_exit_epoch_and_update_churn wrong exit_balance calculation
ed8be8a
@LeanSerra
Merge branch 'electra-support' into electra_predicates
c084913
@LeanSerra
fix additional_epochs calculation in compute_exit_epoch_and_update_churn
6ec0216
@LeanSerra
fix wrong values for constants in minimal config
7da3d5a
@LeanSerra
Merge branch 'electra_predicates' into electra_validator_exit
70d40aa
@LeanSerra
feat process_epoch changes + deposits/consolidation scaffolding
e4e8607
@LeanSerra
feat new is_valid_deposit_signature Electra function
0e53f57
@LeanSerra
feat get_validator_from_deposit Electra changes
12ed2d3
LeanSerra and others added 15 commits April 16, 2025 14:15
@LeanSerra
Merge branch 'electra_process_operations' into electra_consolidations
8dab043
@LeanSerra
Merge branch 'electra-support' into electra_deposits
c049a33
@LeanSerra
Merge branch 'electra_deposits' into electra_process_operations
2b6c4e1
@LeanSerra
Merge branch 'electra_process_operations' into electra_consolidations
bdd2e21
@LeanSerra
Merge branch 'electra-support' into electra_process_operations
2eb2ce3
@LeanSerra
fix added diff lines
5bdef50
@LeanSerra
fix added diff lines
e163179
@LeanSerra
fix fast_process_attestation wrong attesting indices
75bf0b4
@LeanSerra
fix BitList.set should be BitList.set?, fix incorrect pattern matchin…
dd42e10 
…g in with at validate_attestation
@LeanSerra
feat: implement electra deposits (#1424)
d1eacf7
@LeanSerra
fix added diff lines
87a465e
@LeanSerra
fix added diff lines
46717b4
@LeanSerra
fix fast_process_attestation wrong attesting indices
27aeeb0
@LeanSerra
fix BitList.set should be BitList.set?, fix incorrect pattern matchin…
0b8ed91 
…g in with at validate_attestation
@LeanSerra
Merge branch 'electra_process_operations' into electra_consolidations
f3d5531
@LeanSerra LeanSerra marked this pull request as ready for review April 24, 2025 18:57
@LeanSerra LeanSerra requested a review from a team as a code owner April 24, 2025 18:57
Base automatically changed from electra_process_operations to electra-support April 24, 2025 19:16
rodrigo-o
rodrigo-o approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@rodrigo-o rodrigo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! just some minor comments!

@LeanSerra LeanSerra merged commit aae93fb into electra-support Apr 24, 2025
10 of 13 checks passed
@LeanSerra LeanSerra deleted the electra_consolidations branch April 24, 2025 20:54
rodrigo-o pushed a commit that referenced this pull request Apr 25, 2025
@LeanSerra @rodrigo-o
feat: electra consolidations (#1428)
ee7d683
rodrigo-o pushed a commit that referenced this pull request Apr 25, 2025
@LeanSerra @rodrigo-o
feat: electra consolidations (#1428)
a0d8604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigo-o rodrigo-o rodrigo-o approved these changes

Assignees

@LeanSerra LeanSerra

Labels
electra elixir Pull requests that update Elixir code
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeanSerra @rodrigo-o