fix: fixing the CI updating ubuntu and go #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-o
changed the title
rodrigo-o
commented
Apr 16, 2025
| @@ -80,7 +80,7 @@ defmodule Unit.Validator.BlockBuilderTest do | |||
|
|
|||
| [proof] = BlockBuilder.compute_inclusion_proofs(body) | |||
|
|
|||
| assert length(proof) == 9 | |||
| assert length(proof) == 10 | |||
There was a problem hiding this comment.
This was changed in #1432, the change was modifying KZG_COMMITMENT_INCLUSION_PROOF_DEPTH from 9 to 10 as per the updated spec
LeanSerra
approved these changes
Apr 16, 2025
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Most of CI steps where failing unable to fetch the protobuf-compiler
Description
All go version has been updated to 1.24 and all Ubuntu 22.04 to 24.04 (LTS)