fix: handle_gossip_message nesting store into a tuple #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeanSerra
changed the title
LeanSerra
changed the title
LeanSerra
changed the title
rodrigo-o
reviewed
Apr 23, 2025
| @@ -19,7 +19,7 @@ defmodule LambdaEthereumConsensus.P2P.Gossip.BlobSideCar do | |||
| Logger.debug("[Gossip] Blob sidecar received, with index #{blob_index}") | |||
| Libp2pPort.validate_message(msg_id, :accept) | |||
| # TODO: (#1406) Enhance the API to reduce unnecessary wrappers (:ok + list) | |||
| PendingBlocks.process_blobs(store, {:ok, [blob]}) | |||
| PendingBlocks.process_blobs(store, {:ok, [blob]}) |> then(&elem(&1, 1)) | |||
There was a problem hiding this comment.
Couldn't this return an {:error, reason} in which case we'll be returning the reason here?
There was a problem hiding this comment.
PendingBlocks.process_blobs returns the previous store as {:ok, store} even if the blob isn't processed
rodrigo-o
approved these changes
Apr 23, 2025
|
Left #1444 as an issue to add tests for this so we don't have regressions again |
LeanSerra
added a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When receiving blobs by gossip the GenServer was crashing because of a pattern matching error as inside of
handle_gossip_messagewe were calling the functionPendingBlocks.process_blobsthat returned {:ok, store} but the functionhandle_gossip_messagewas only supposed to return storeDescription
PendingBlocks.process_blobsextract the second element of the tuple and return only that