This repository was archived by the owner on Jul 22, 2024. It is now read-only.
support multiple transactions #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #706 +/- ##
==========================================
+ Coverage 92.11% 92.13% +0.02%
==========================================
Files 52 52
Lines 11360 11397 +37
==========================================
+ Hits 10464 10501 +37
Misses 896 896
|
juanbono
suggested changes
Jun 28, 2023
…lass/starknet_in_rust into multiple-transactions-simulation
juanbono
approved these changes
Jun 29, 2023
matias-gonz
approved these changes
Jun 30, 2023
Comment on lines
+494
to
+502
| assert!(context[0].validate_info.is_some()); | ||
| assert!(context[0].call_info.is_none()); | ||
| assert!(context[0].fee_transfer_info.is_none()); | ||
| assert!(context[1].validate_info.is_some()); | ||
| assert!(context[1].call_info.is_none()); | ||
| assert!(context[1].fee_transfer_info.is_none()); | ||
| assert!(context[2].validate_info.is_some()); | ||
| assert!(context[2].call_info.is_none()); | ||
| assert!(context[2].fee_transfer_info.is_none()); |
There was a problem hiding this comment.
he performed loop unrolling (?)
There was a problem hiding this comment.
blazing fast tests
Oppen
approved these changes
Jun 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for multiple transactions simulations at once.
Waiting for #703 to be finish.
Closes #700
Checklist