Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Improve naming of internal transaction methods #714

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Conversation

juanbono
Copy link
Collaborator

@juanbono juanbono commented Jul 3, 2023

Improve naming of internal transaction methods

Description

This PR improves how we name internal transaction names. The names used were confusing.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

Codecov Report

Merging #714 (7617f93) into main (5361f71) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files          52       52           
  Lines       11792    11779   -13     
=======================================
- Hits        10892    10880   -12     
+ Misses        900      899    -1     
Impacted Files Coverage Δ
src/execution/execution_entry_point.rs 97.35% <ø> (ø)
src/syscalls/business_logic_syscall_handler.rs 77.56% <ø> (ø)
src/syscalls/syscall_response.rs 74.28% <ø> (ø)
src/execution/mod.rs 97.55% <100.00%> (-0.03%) ⬇️
src/transaction/declare.rs 98.63% <100.00%> (-0.02%) ⬇️
src/transaction/declare_v2.rs 86.18% <100.00%> (+0.11%) ⬆️
src/transaction/deploy.rs 99.02% <100.00%> (-0.03%) ⬇️
src/transaction/deploy_account.rs 96.87% <100.00%> (-0.05%) ⬇️
src/transaction/invoke_function.rs 99.31% <100.00%> (-0.01%) ⬇️
src/transaction/l1_handler.rs 96.94% <100.00%> (-0.03%) ⬇️

... and 2 files with indirect coverage changes

@matias-gonz matias-gonz added this pull request to the merge queue Jul 3, 2023
@juanbono juanbono self-assigned this Jul 3, 2023
@juanbono juanbono added this to the starknet_in_rust 0.1.1 milestone Jul 3, 2023
Merged via the queue into main with commit 3d84f66 Jul 3, 2023
@juanbono juanbono deleted the improve_naming branch July 4, 2023 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants