Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fix declare miscalculation #760

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Fix declare miscalculation #760

merged 3 commits into from
Jul 4, 2023

Conversation

mmsc2
Copy link
Contributor

@mmsc2 mmsc2 commented Jul 4, 2023 •
edited
Loading

TITLE

Description

solves ticket #758

use this transaction for testing https://starkscan.co/tx/`0x00fca7e0a32102ace7985ac6ef95c8a018ac949748d4873c5c48829dc6a2ef80`

@mmsc2 mmsc2 marked this pull request as ready for review July 4, 2023 15:57
@mmsc2 mmsc2 linked an issue Jul 4, 2023 that may be closed by this pull request
Declare transaction hash mismatch #758
Closed
juanbono
juanbono approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a comment with a link to the transaction we used for the test

@mmsc2 mmsc2 added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit 66a978b Jul 4, 2023
@juanbono juanbono deleted the FixMismatchHashInDeclareV1 branch July 31, 2023 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanbono juanbono juanbono approved these changes

@matias-gonz matias-gonz matias-gonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declare transaction hash mismatch
3 participants
@mmsc2 @juanbono @matias-gonz