Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Update verify_version #777

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Update verify_version #777

merged 8 commits into from
Jul 6, 2023

Conversation

matias-gonz
Copy link
Contributor

Closes #772

@matias-gonz matias-gonz self-assigned this Jul 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #777 (8dc0b3d) into main (384f459) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 8dc0b3d differs from pull request most recent head d8af0bf. Consider uploading reports for the commit d8af0bf to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
+ Coverage   92.50%   92.57%   +0.07%     
==========================================
  Files          51       51              
  Lines       12098    11957     -141     
==========================================
- Hits        11191    11069     -122     
+ Misses        907      888      -19     
Impacted Files Coverage Δ
src/transaction/error.rs 100.00% <ø> (ø)
src/transaction/mod.rs 90.47% <ø> (ø)
src/transaction/declare.rs 98.61% <100.00%> (-0.03%) ⬇️
src/transaction/declare_v2.rs 86.82% <100.00%> (+0.63%) ⬆️
src/transaction/verify_version.rs 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@matias-gonz matias-gonz marked this pull request as draft July 5, 2023 19:25
@matias-gonz matias-gonz marked this pull request as ready for review July 5, 2023 19:25
@matias-gonz matias-gonz enabled auto-merge July 6, 2023 20:47
@matias-gonz matias-gonz added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit bb92a8b Jul 6, 2023
@MegaRedHand MegaRedHand deleted the update_verify_version branch July 7, 2023 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the logic in declare's verify_version method
4 participants