Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

InvokeDoc #782

Merged
merged 8 commits into from
Jul 10, 2023
Merged

InvokeDoc #782

merged 8 commits into from
Jul 10, 2023

Conversation

mmsc2
Copy link
Contributor

@mmsc2 mmsc2 commented Jul 6, 2023

TITLE

Description

solves issue #738

@mmsc2 mmsc2 linked an issue Jul 6, 2023 that may be closed by this pull request
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, I think we should document every function explaining what is their purpose and without being specific about details like "Executes X in the CairoVM" but instead explaining that the validate entrypoint is what is being executed.

@@ -27,6 +27,7 @@ use num_traits::Zero;

use super::Transaction;

/// Represents an InvokeFunction transaction in the starknet network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention it is called INVOKE_FUNCTION in the RPC API and in starkscan.

@juanbono juanbono added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 87be4f0 Jul 10, 2023
@juanbono juanbono deleted the InvokeFunctionDoc branch July 31, 2023 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document transaction/invoke_function module
4 participants