This repository was archived by the owner on Jul 22, 2024. It is now read-only.
DeclareV2 class hash fix #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need this value when we're adding the declared class to storage so this change moves the computation from the transaction hash calculation function into DeclareV2::new().
The code used the _transaction hash_ instead of the Sierra class hash to add the declared class to storage. This change fixes that to use the class hash instead.
Codecov Report
@@ Coverage Diff @@
## main #788 +/- ##
==========================================
+ Coverage 92.53% 93.17% +0.63%
==========================================
Files 52 52
Lines 12119 12127 +8
==========================================
+ Hits 11214 11299 +85
+ Misses 905 828 -77
|
matias-gonz
approved these changes
Jul 7, 2023
juanbono
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeclareV2 should declare the class with the correct class hash
Description
DeclareV2 code used the transaction hash (maybe we could use the Rust type system to make sure no such problems are there in the code?) instead of the class hash when adding the declared class to storage.