Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

feat: add keccak syscall support #794

Merged
merged 33 commits into from
Aug 2, 2023
Merged

feat: add keccak syscall support #794

merged 33 commits into from
Aug 2, 2023

Conversation

MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Jul 7, 2023

Closes #786
Blocked by #863

Description

This PR adds support for the keccak builtin (AKA keccak_syscall).

Note: this PR needs an update to the latest cairo-lang version before being merged.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@MegaRedHand MegaRedHand force-pushed the keccak-builtin-support branch from 62eb4ff to eab97fb Compare July 7, 2023 21:04
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #794 (b1805e8) into main (51ec5a8) will decrease coverage by 0.13%.
The diff coverage is 70.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   91.21%   91.09%   -0.13%     
==========================================
  Files          54       54              
  Lines       13402    13483      +81     
==========================================
+ Hits        12225    12282      +57     
- Misses       1177     1201      +24     
Files Changed Coverage Δ
src/syscalls/business_logic_syscall_handler.rs 76.69% <62.06%> (-1.26%) ⬇️
src/syscalls/syscall_response.rs 76.74% <85.71%> (+1.74%) ⬆️
src/syscalls/syscall_request.rs 81.11% <93.75%> (+1.23%) ⬆️
src/syscalls/syscall_info.rs 94.44% <100.00%> (+0.15%) ⬆️

@MegaRedHand MegaRedHand marked this pull request as ready for review July 10, 2023 13:55
@MegaRedHand MegaRedHand marked this pull request as draft July 10, 2023 15:02
@MegaRedHand
Copy link
Contributor Author

Leaving this PR as draft for now, until we can add some tests for it.

@kkovaacs
Copy link
Contributor

I think this PR is missing adding the appropriate weight to DEFAULT_CAIRO_RESOURCE_FEE_WEIGHTS.

@MegaRedHand MegaRedHand marked this pull request as ready for review August 1, 2023 14:51
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix keccak syscall cost

@juanbono juanbono requested a review from Oppen August 2, 2023 14:35
@Oppen Oppen added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit 8e51497 Aug 2, 2023
@MegaRedHand MegaRedHand deleted the keccak-builtin-support branch August 2, 2023 16:06
@juanbono juanbono changed the title feat: add keccak builtin support feat: add keccak syscall support Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use starknet_keccak layout when the contract uses the keccak builtin
6 participants