This repository was archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62eb4ff
to
eab97fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 91.21% 91.09% -0.13%
==========================================
Files 54 54
Lines 13402 13483 +81
==========================================
+ Hits 12225 12282 +57
- Misses 1177 1201 +24
|
Leaving this PR as draft for now, until we can add some tests for it. |
I think this PR is missing adding the appropriate weight to |
juanbono
approved these changes
Aug 1, 2023
juanbono
suggested changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix keccak syscall cost
juanbono
approved these changes
Aug 2, 2023
Oppen
suggested changes
Aug 2, 2023
4 tasks
matias-gonz
reviewed
Aug 2, 2023
Oppen
approved these changes
Aug 2, 2023
keccak
builtin supportkeccak
syscall support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #786
Blocked by #863
Description
This PR adds support for the
keccak
builtin (AKAkeccak_syscall
).Note: this PR needs an update to the latest
cairo-lang
version before being merged.Checklist