This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add hash_value to l1 handler new #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbono
approved these changes
Jul 10, 2023
Oppen
suggested changes
Jul 10, 2023
src/transaction/l1_handler.rs
Outdated
| @@ -46,17 +46,21 @@ impl L1Handler { | |||
| nonce: Felt252, | |||
| chain_id: Felt252, | |||
| paid_fee_on_l1: Option<Felt252>, | |||
| hash_value: Option<Felt252>, | |||
| ) -> Result<L1Handler, TransactionError> { | |||
There was a problem hiding this comment.
Please use a different constructor for this. The user should clearly see that mistakes could lead to inconsistencies by simply looking up the name.
Codecov Report
@@ Coverage Diff @@
## main #802 +/- ##
=======================================
Coverage 93.17% 93.18%
=======================================
Files 52 52
Lines 12127 12144 +17
=======================================
+ Hits 11299 11316 +17
Misses 828 828
|
Oppen
approved these changes
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #803
Checklist