This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add version query #810
Merged
Add version query #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #810 +/- ##
==========================================
- Coverage 91.91% 91.82% -0.09%
==========================================
Files 52 52
Lines 12275 12373 +98
==========================================
+ Hits 11282 11361 +79
- Misses 993 1012 +19
|
juanbono
reviewed
Jul 12, 2023
src/definitions/constants.rs
Outdated
| @@ -14,6 +14,11 @@ pub(crate) const N_DEFAULT_TOPICS: usize = 1; // Events have one default topic. | |||
| pub(crate) const CONSUMED_MSG_TO_L2_ENCODED_DATA_SIZE: usize = | |||
| (L1_TO_L2_MSG_HEADER_SIZE + 1) - CONSUMED_MSG_TO_L2_N_TOPICS; | |||
|
|
|||
| lazy_static! { | |||
| pub(crate) static ref VERSION_QUERY: Felt252 = | |||
There was a problem hiding this comment.
the name in cairo-lang is VERSION_QUERY_BASE I think we should have the same name because VERSION_QUERY has an specific meaning in this context:
QUERY_VERSION = QUERY_VERSION_BASE + TRANSACTION_VERSION
Where TRANSACTION_VERSION = 1
Oppen
approved these changes
Jul 12, 2023
SantiagoPittella
previously requested changes
Jul 12, 2023
juanbono
approved these changes
Jul 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
solves issue #799