Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Add from_program_json_and_class_hash #836

Merged
merged 12 commits into from
Jul 27, 2023

Conversation

matias-gonz
Copy link
Contributor

Closes #796

@matias-gonz matias-gonz self-assigned this Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #836 (c1495fa) into main (6805c61) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
+ Coverage   91.75%   91.77%   +0.02%     
==========================================
  Files          54       54              
  Lines       12896    12929      +33     
==========================================
+ Hits        11833    11866      +33     
  Misses       1063     1063              
Files Changed Coverage Δ
src/services/api/contract_class_errors.rs 0.00% <ø> (ø)
.../api/contract_classes/deprecated_contract_class.rs 82.95% <100.00%> (+2.02%) ⬆️

Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@matias-gonz matias-gonz requested a review from juanbono July 19, 2023 14:23
@matias-gonz matias-gonz enabled auto-merge July 20, 2023 17:40
@matias-gonz matias-gonz added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 483883c Jul 27, 2023
@juanbono juanbono deleted the add_contract_class_from_program_json_and_class_hash branch July 31, 2023 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate contract class constructors in 2, one with and one without class_hash calculation
5 participants