Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Add documentation to syscalls/deprecated_syscall_response module #866

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

fguthmann
Copy link
Contributor

TITLE

Description

Add documentation to syscalls/deprecated_syscall_response module

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
  • Documentation has been added/updated.

@fguthmann fguthmann linked an issue Jul 28, 2023 that may be closed by this pull request
@fguthmann fguthmann marked this pull request as ready for review July 28, 2023 12:51
Copy link
Collaborator

@SantiagoPittella SantiagoPittella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple comments about documentation in Rust.
This is a nice reading about the topic:
https://doc.rust-lang.org/rustdoc/how-to-write-documentation.html

@codecov-commenter
Copy link

Codecov Report

Merging #866 (f646ffa) into main (f659e05) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #866   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          54       54           
  Lines       12930    12933    +3     
=======================================
+ Hits        11868    11871    +3     
  Misses       1062     1062           
Files Changed Coverage Δ
src/syscalls/deprecated_syscall_response.rs 88.50% <100.00%> (+0.17%) ⬆️

@juanbono juanbono added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit 981f0f4 Jul 31, 2023
@juanbono juanbono deleted the document-syscalls/deprecated_syscall_response-module branch July 31, 2023 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document syscalls/deprecated_syscall_response module
4 participants