Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Ignore max_fee field during fee estimation #869

Merged
merged 6 commits into from
Jul 31, 2023
Merged

Conversation

xqft
Copy link
Contributor

@xqft xqft commented Jul 31, 2023

Ignore max_fee field during fee estimation

Description

Closes #870. This change makes estimate_fee() create a tx with a maximum max_fee.

Checklist

  • Linked to Github Issue
  • Unit tests added

@codecov-commenter
Copy link

Codecov Report

Merging #869 (14e998e) into main (cdf9880) will increase coverage by 0.00%.
The diff coverage is 95.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   91.78%   91.79%           
=======================================
  Files          54       54           
  Lines       12939    12986   +47     
=======================================
+ Hits        11876    11920   +44     
- Misses       1063     1066    +3     
Files Changed Coverage Δ
src/transaction/declare.rs 93.50% <75.00%> (-0.11%) ⬇️
src/transaction/declare_v2.rs 83.72% <75.00%> (-0.06%) ⬇️
src/transaction/deploy_account.rs 88.85% <75.00%> (-0.15%) ⬇️
src/lib.rs 98.73% <100.00%> (+0.02%) ⬆️
src/transaction/invoke_function.rs 99.57% <100.00%> (+<0.01%) ⬆️
src/transaction/mod.rs 93.22% <100.00%> (+2.74%) ⬆️

@xqft xqft marked this pull request as ready for review July 31, 2023 14:12
@xqft xqft enabled auto-merge July 31, 2023 19:03
@xqft xqft added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit cdcab8c Jul 31, 2023
@juanbono juanbono deleted the esimate_ignore_max_fee branch July 31, 2023 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore max_fee when executing transactions.
4 participants