Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Change Box to Arc for CompiledClass #926

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

fguthmann
Copy link
Contributor

@fguthmann fguthmann commented Aug 17, 2023

Change Box to Arc for CompiledClass #926

Description

Change Box to Arc for CompiledClass since they get copied most of the time between the caches and their users, and are essentially read-only.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
  • Documentation has been added/updated.

@fguthmann fguthmann linked an issue Aug 17, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #926 (4c3e5d5) into main (673985f) will not change coverage.
The diff coverage is 64.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #926   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          54       54           
  Lines       13597    13597           
=======================================
  Hits        12350    12350           
  Misses       1247     1247           
Files Changed Coverage Δ
...rc/services/api/contract_classes/compiled_class.rs 4.34% <25.00%> (ø)
src/state/in_memory_state_reader.rs 90.76% <33.33%> (ø)
src/state/cached_state.rs 90.43% <57.14%> (ø)
src/transaction/deploy.rs 90.43% <75.00%> (ø)
src/execution/execution_entry_point.rs 97.27% <100.00%> (ø)
src/state/state_cache.rs 96.33% <100.00%> (ø)
src/transaction/declare_v2.rs 83.72% <100.00%> (ø)

@fguthmann fguthmann marked this pull request as ready for review August 17, 2023 12:56
@juanbono juanbono added this pull request to the merge queue Aug 22, 2023
@juanbono juanbono modified the milestone: Improvements Aug 22, 2023
Merged via the queue into main with commit 89a36ff Aug 22, 2023
@juanbono juanbono deleted the use-arc-for-compiledclass-variants branch August 22, 2023 21:08
fguthmann added a commit that referenced this pull request Sep 22, 2023
Co-authored-by: fannyguthmann <[email protected]>
Co-authored-by: Juan Bono <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use Arc for CompiledClass variants
4 participants