Fixed date validation not accepting relative dates #4825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data validation does not accept _any_ value that `strtotime` understands, as it does `date_parse` with `check_date` afterwards. There was an issue for this, but was closed, although I could reproduce it. https://github.com/laravel/docs/issues/2542 `app('validator')->make(['foo' => 'yesterday'], ['foo' => ['date']])->validate()`
|
Another option would be using 'absolute', but with timezone things I find that more confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date validation does not accept any value that
strtotimeunderstands, as it doesdate_parsewithcheck_dateafterwards.There was an issue for this, but was closed, although I could reproduce it.
https://github.com/laravel/docs/issues/2542
app('validator')->make(['foo' => 'yesterday'], ['foo' => ['date']])->validate()edit: Fixed typo