Skip to content

[5.5] Make it clear that /vendor/mail/markdown refers to the plain text version of emails #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

mikew1
Copy link

@mikew1 mikew1 commented Dec 13, 2018

The clarification that 'markdown' directory refers to plain text version of emails is also applicable to 5.5!

After the discussion here it appears 5.6+ docs were updated, but 5.5 weren't. LTS is still first recourse for me at least at this time.

…of emails (just make this paragraph identical to the 5.6+ docs - the point applies equally in 5.5LTS which are still docs of first recourse for some!)
@driesvints driesvints changed the title Make it clear that /vendor/mail/markdown refers to the plain text version of emails [5.7] Make it clear that /vendor/mail/markdown refers to the plain text version of emails Dec 13, 2018
@mikew1 mikew1 changed the title [5.7] Make it clear that /vendor/mail/markdown refers to the plain text version of emails [5.5] Make it clear that /vendor/mail/markdown refers to the plain text version of emails Dec 13, 2018
@mikew1 mikew1 changed the title [5.5] Make it clear that /vendor/mail/markdown refers to the plain text version of emails [5.7] Make it clear that /vendor/mail/markdown refers to the plain text version of emails Dec 13, 2018
@mikew1
Copy link
Author

mikew1 commented Dec 13, 2018

Apologies - wasn't sure why you tagged this "[5.7]".... - the change is a suggestion applicable only to the 5.5 docs. This is my first pull request, just finding my feet here :)

@taylorotwell taylorotwell merged commit 09cb90f into laravel:5.5 Dec 13, 2018
@driesvints driesvints changed the title [5.7] Make it clear that /vendor/mail/markdown refers to the plain text version of emails [5.5] Make it clear that /vendor/mail/markdown refers to the plain text version of emails Dec 13, 2018
@driesvints
Copy link
Member

@mikew1 you're right! My bad, I used the wrong tag. Sorry about that!

@mikew1
Copy link
Author

mikew1 commented Dec 13, 2018

@driesvints no problem :)

taylorotwell added a commit that referenced this pull request Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants