[5.7] Allows for custom formatter when using Slack Log driver #26377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case
Allow for a custom formatter defined in
logging.phpconfig file, when using the Slack Log driver.More info
Looking at the source code of LogManager, it allows for using a custom formatter if defined in the
logging.phpconfig file. However the method of LogManager that creates the Slack driver does not pass on the$configarray to the appropriate method. This PR addresses this by passing the missing configuration array to theprepareHandler()method. This is a non breaking change as the existing implementation will fallback to the default formatter if none defined in thelogging.phpconfig file.