Rename url to href in navigation items for consistency

[oketafred]

This pull request renames the url property to href to align with the NavItem interface definition.

The current NavItem interface is structured as follows, and it does not include a url property, necessitating this change:

export interface NavItem {
    title: string;
    href: string;
    icon?: LucideIcon;
    isActive?: boolean;
}

By updating url to href, we ensure consistency with the existing type definition and avoid potential issues related to property mismatches.

[thewebartisan7]

I just saw this one; I'll check yours to see if it's a better approach. I did the opposite by renaming 'NavItem' from 'href' to 'url' in a few places.

[tnylea]

Thanks @oketafred and @thewebartisan7. I agree that we should keep it consistent. I was researching if url or href is more common and I've seen href used more often when referring to links in a React application.

Let's stick with that. @thewebartisan7 I'm going to close your PR and work on getting this one merged in.

[thewebartisan7]

Thanks @oketafred and @thewebartisan7. I agree that we should keep it consistent. I was researching if url or href is more common and I've seen href used more often when referring to links in a React application.

Let's stick with that. @thewebartisan7 I'm going to close your PR and work on getting this one merged in.

Consistency is key for me as well, and personally, I prefer using href over url in this case. However, I found it a bit quicker to switch to url in the Vue app. I'll test this branch tomorrow.

[tnylea]

@oketafred Looks good. Thanks