Skip to content

feature: support websocket connections and passing in HTTP headers to websockets and SSE connections #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025

Conversation

pmohan6
Copy link
Contributor

@pmohan6 pmohan6 commented Apr 6, 2025

Add support for connecting over websockets
Add support for passing in HTTP headers to websocket and SSE connections.
Tested against a real websocket server hosted on smithery.ai. Added an example.
Tested passing headers against a personally hosted SSE server. Added an example.

Added unit tests for websockets.

You can run unit tests as follows:

uv run pytest tests/test_websocket.py

Copy link
Collaborator

@saqadri saqadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in getting to this @pmohan6. This is an excellent PR, and can be merged as-is! Thank you for driving this!

@saqadri saqadri merged commit 325b5a7 into lastmile-ai:main Apr 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants