Skip to content

Fix/secrets tracking #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 18, 2025
Merged

Fix/secrets tracking #2

merged 4 commits into from
Jan 18, 2025

Conversation

evalstate
Copy link
Contributor

Use .secrets.yaml.example files rather than .secrets.yaml to avoid user footguns.

@evalstate
ignore secrets files within "examples"
57b58f8
@evalstate
Create secrets example files.
722ff4a 
Untrack actual secrets files.
Update README.md to reflect need to copy .yaml.example to .yaml before Update
@evalstate
Remove .secrets form tracking
26c8d13 
Add .secrets.yaml.examples files.
Update README
saqadri
saqadri approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@saqadri saqadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One comment, otherwise looks good

@saqadri saqadri merged commit 991b095 into lastmile-ai:main Jan 18, 2025
@saqadri
Copy link
Collaborator

saqadri commented Jan 18, 2025

Thank you @evalstate!! First contribution already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saqadri saqadri saqadri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evalstate @saqadri