Support proper conversion from MCP's image content to OpenAI's image content part #210
Conversation
| ) | ||
| if content.resource.mimeType.startswith("image/"): | ||
| return ChatCompletionContentPartImageParam( | ||
| type="image_url", |
There was a problem hiding this comment.
Is it always base64 based btw, or can it be a URI as well?
There was a problem hiding this comment.
Yup, MCP's ImageContent only provides base64 encoded data.
…_content_to_mcp_content
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| ) | ||
| ) | ||
| else: | ||
| raise ValueError(f"Unexpected content type: {c.type}") | ||
| raise ValueError(f"Unexpected content type: {c["type"]}") |
There was a problem hiding this comment.
There's a syntax error in this f-string where double quotes are nested inside double quotes when accessing the dictionary key. This will cause a Python syntax error at runtime.
Consider using single quotes inside the f-string:
raise ValueError(f"Unexpected content type: {c['type']}")Or alternatively, use single quotes for the f-string itself:
raise ValueError(f'Unexpected content type: {c["type"]}')| raise ValueError(f"Unexpected content type: {c["type"]}") | |
| raise ValueError(f"Unexpected content type: {c['type']}") |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| """ | ||
| import re | ||
|
|
||
| match = re.match(r"data:(image/\w+);base64,(.*)", image_url) |
There was a problem hiding this comment.
The regex pattern r"data:(image/\w+);base64,(.*)" is too restrictive for image MIME types. The \w+ only matches alphanumeric characters and underscores, but valid MIME types like image/svg+xml contain additional characters such as +.
Consider updating to a more inclusive pattern like:
r"data:(image/[\w.+-]+);base64,(.*)"
This will properly handle all standard image MIME types including SVG, PNG, JPEG, and others that may contain special characters in their subtype.
| match = re.match(r"data:(image/\w+);base64,(.*)", image_url) | |
| match = re.match(r"data:(image/[\w.+-]+);base64,(.*)", image_url) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Approving to unblock @StreetLamb. Please update with conflicts resolved and merge at your convenience!
Fixes #201