Skip to content

Ensure base_url is always used for OpenAI clients #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

mcolyer
Copy link
Contributor

@mcolyer mcolyer commented Feb 13, 2025

It looks like there was at least one place where this wasn't happening, not sure if there are others.

Copy link
Collaborator

@saqadri saqadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof, great catch, thank you @mcolyer! I'll review if there's any others but I think you've got it

@saqadri saqadri merged commit 8461954 into lastmile-ai:main Feb 13, 2025
4 checks passed
@saqadri
Copy link
Collaborator

saqadri commented Feb 13, 2025

Will publish a patch today

@saqadri
Copy link
Collaborator

saqadri commented Feb 19, 2025

@mcolyer I've published v0.0.7 which includes this fix. Thank you again for the contribution, and please let me know if there are any other requests or issues with mcp-agent that we should prioritize addressing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants