Skip to content

fix examples #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

fix examples #92

merged 2 commits into from
Mar 31, 2025

Conversation

boxbag
Copy link
Contributor

@boxbag boxbag commented Mar 31, 2025

Fixes a variety of problems in examples found during testing

  1. Indentation in mcp_hello_world was incorrect, causing the example to not run after client is instantiated
  2. References to saqadri local filesystem in mcp_basic_slack_agent, mcp_model_selector, workflow_evaluator_optimizer`
  3. mcp_basic_slack requires path to folder on local filesystem, similar to other examples
  4. mcp_researcher could not resolve relative path ./agent_folder. Had to pass the full path using os.path.abspath. Also need to create the agent_folder directory if it doesn't exist on local filesystem

Example error from mcp_basic_slack

Error accessing directory /Users/saqadri/Desktop: Error: ENOENT: no such file or 
directory, stat '/Users/saqadri/Desktop'
    at async Object.stat (node:internal/fs/promises:1037:18)
    at async file:///Users/bochen/.npm/_npx/a3241bba59c344f5/node_modules/@modelcontextprotocol/server-filesystem/dist/index.js:33:23
    at async Promise.all (index 0)
    at async file:///Users/bochen/.npm/_npx/a3241bba59c344f5/node_modules/@modelcontextprotocol/server-filesystem/dist/index.js:31:1 {
  errno: -2,
  code: 'ENOENT',
  syscall: 'stat',
  path: '/Users/saqadri/Desktop'
}

Example error from mcp_researcher

{"level":"INFO","timestamp":"2025-03-31T13:21:05.308384","namespace":"mcp_agent.mcp.stdio.mcpserver.stderr","message":"docker: Error response from daemon: create ./agent_folder: \"./agent_folder\" includes invalid characters for a local volume name, only \"[a-zA-Z0-9][a-zA-Z0-9_.-]\" are allowed. If you intended to pass a host directory, use absolute path.\nSee 'docker run --help'."}

Copy link
Collaborator

@saqadri saqadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥹 🙏🏼 @boxbag keep the fixes coming!

@saqadri saqadri merged commit 0462b8d into lastmile-ai:main Mar 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants