fix: simulate mac + windows releases, fix openssl root path (#329)

Removes some obsolete openSSL CI config, as well as enables release
simulation for Mac + Windows (previously only on Ubunutu.)

This fixes Windows releases by setting `LD_DYNAMIC_LINK_BOOST=OFF` when
building shared libraries. This was already intended to be enabled, but
it was only being set on the debug releases (`build-windows.sh`). Now it
is present in both the debug and non-debug releases.

Author: cwaldren-ld

.github/actions/ci/action.yml

@@ -25,6 +25,10 @@ inputs:
     description: 'Whether to run ./build-release.sh for the CMake target'
     required: false
     default: 'false'
+  simulate_windows_release:
+    description: 'Whether to run ./build-release-windows.sh for the CMake target'
+    required: false
+    default: 'false'
 
 runs:
   using: composite
@@ -60,9 +64,19 @@ runs:
       # This uses the binary, versus "make tests" because the binary
       # has better performance and output.
       run: ./build/gtest_${{ inputs.cmake_target }}
-    - name: Simulate Release
+
+    - name: Simulate Release (Linux/MacOS)
       if: inputs.simulate_release == 'true'
       shell: bash
       run: ./scripts/build-release.sh ${{ inputs.cmake_target }}
       env:
         BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }}
+        OPENSSL_ROOT_DIR: ${{ steps.install-openssl.outputs.OPENSSL_ROOT_DIR }}
+
+    - name: Simulate Release (Windows)
+      if: inputs.simulate_windows_release == 'true'
+      shell: bash
+      run: ./scripts/build-release-windows.sh ${{ inputs.cmake_target }}
+      env:
+        BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }}
+        OPENSSL_ROOT_DIR: ${{ steps.install-openssl.outputs.OPENSSL_ROOT_DIR }}

.github/actions/sdk-release/action.yml

@@ -37,7 +37,9 @@ runs:
     - name: Install boost
       uses: ./.github/actions/install-boost
       id: install-boost
-
+    - name: Install OpenSSL
+      uses: ./.github/actions/install-openssl
+      id: install-openssl
     - name: Build Linux Artifacts
       if: runner.os == 'Linux'
       shell: bash
@@ -49,6 +51,7 @@ runs:
       env:
         WORKSPACE: ${{ inputs.sdk_path }}
         BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }}
+        OPENSSL_ROOT_DIR: ${{ steps.install-openssl.outputs.OPENSSL_ROOT_DIR }}
 
     - name: Archive Release Linux - GCC/x64/Static
       if: runner.os == 'Linux'
@@ -92,29 +95,13 @@ runs:
       if: runner.os == 'Windows'
       uses: ilammy/msvc-dev-cmd@v1
 
-    - name: Upgrade OpenSSL
-      if: runner.os == 'Windows'
-      shell: bash
-      run: |
-        choco upgrade openssl --no-progress
-    - name: Determine OpenSSL Installation Directory
-      if: runner.os == 'Windows'
-      shell: bash
-      run: |
-        if [ -d "C:\Program Files\OpenSSL-Win64" ]; then
-          echo "OPENSSL_ROOT_DIR=C:\Program Files\OpenSSL-Win64" >> "$GITHUB_ENV"
-        else
-          echo "OPENSSL_ROOT_DIR=C:\Program Files\OpenSSL" >> "$GITHUB_ENV"
-        fi
     - name: Build Windows Artifacts
       if: runner.os == 'Windows'
       shell: bash
       env:
-        OPENSSL_ROOT_DIR: ${{ env.OPENSSL_ROOT_DIR }}
-        BOOST_LIBRARY_DIR: 'C:\local\boost_1_81_0\lib64-msvc-14.3'
-        BOOST_LIBRARYDIR: 'C:\local\boost_1_81_0\lib64-msvc-14.3'
         BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }}
-      run: ./scripts/build-windows.sh ${{ inputs.sdk_cmake_target }}
+        OPENSSL_ROOT_DIR: ${{ steps.install-openssl.outputs.OPENSSL_ROOT_DIR }}
+      run: ./scripts/build-release-windows.sh ${{ inputs.sdk_cmake_target }}
 
     - name: Archive Release Windows - MSVC/x64/Static
       if: runner.os == 'Windows'
@@ -168,14 +155,11 @@ runs:
       id: brew-action
       if: runner.os == 'macOS'
       shell: bash
-      run: |
-        echo "OPENSSL_ROOT_DIR=$(brew --prefix openssl@3)" >> "$GITHUB_ENV"
-        export OPENSSL_ROOT_DIR=$(brew --prefix openssl@3)
-        
-        ./scripts/build-release.sh ${{ inputs.sdk_cmake_target }}
+      run: ./scripts/build-release.sh ${{ inputs.sdk_cmake_target }}
       env:
         WORKSPACE: ${{ inputs.sdk_path }}
         BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }}
+        OPENSSL_ROOT_DIR: ${{ steps.install-openssl.outputs.OPENSSL_ROOT_DIR }}
 
     - name: Archive Release Mac - AppleClang/x64/Static
       if: runner.os == 'macOS'

.github/workflows/client.yml

@@ -45,6 +45,7 @@ jobs:
         with:
           cmake_target: launchdarkly-cpp-client
           platform_version: 12
+          simulate_release: true
   build-test-client-windows:
     runs-on: windows-2022
     steps:
@@ -58,3 +59,4 @@ jobs:
           cmake_target: launchdarkly-cpp-client
           platform_version: 2022
           toolset: msvc
+          simulate_windows_release: true

.github/workflows/server-redis.yml

@@ -33,6 +33,7 @@ jobs:
           cmake_target: launchdarkly-cpp-server-redis-source
           platform_version: 12
           run_tests: false # TODO: figure out how to run Redis service on Mac
+          simulate_release: true
   build-test-redis-windows:
     runs-on: windows-2022
     steps:
@@ -47,3 +48,4 @@ jobs:
           platform_version: 2022
           toolset: msvc
           run_tests: false # TODO: figure out how to run Redis service on Windows
+          simulate_windows_release: true

.github/workflows/server.yml

@@ -46,6 +46,7 @@ jobs:
         with:
           cmake_target: launchdarkly-cpp-server
           platform_version: 12
+          simulate_release: true
   build-test-server-windows:
     runs-on: windows-2022
     steps:
@@ -56,3 +57,4 @@ jobs:
           cmake_target: launchdarkly-cpp-server
           platform_version: 2022
           toolset: msvc
+          simulate_windows_release: true

CMakeLists.txt

@@ -12,6 +12,15 @@ project(
         LANGUAGES CXX C
 )
 
+# Allow BOOST_ROOT to be set by CI without warnings.
+if (POLICY CMP0074)
+    cmake_policy(SET CMP0074 NEW)
+endif ()
+
+if (POLICY CMP0144)
+    cmake_policy(SET CMP0144 NEW)
+endif ()
+
 include(GNUInstallDirs)
 
 option(BUILD_TESTING "Top-level switch for testing. Turn off to disable unit and contract tests." ON)

scripts/build-release-windows.sh

@@ -0,0 +1,65 @@
+#!/bin/bash -e
+
+# Call this script with a CMakeTarget
+# ./scripts/build-release launchdarkly-cpp-client
+
+set -e
+
+# Special case: unlike the other targets, enabling redis support will pull in redis++ and hiredis dependencies at
+# configuration time. To ensure this only happens when asked, disable the support by default.
+build_redis="OFF"
+if [ "$1" == "launchdarkly-cpp-server-redis-source" ]; then
+  build_redis="ON"
+fi
+
+# Build a static release.
+mkdir -p build-static && cd build-static
+mkdir -p release
+cmake -G Ninja -D CMAKE_BUILD_TYPE=Release \
+               -D LD_BUILD_REDIS_SUPPORT="$build_redis" \
+               -D BUILD_TESTING=OFF \
+               -D CMAKE_INSTALL_PREFIX=./release ..
+
+cmake --build . --target "$1"
+cmake --install .
+cd ..
+
+# Build a dynamic release.
+mkdir -p build-dynamic && cd build-dynamic
+mkdir -p release
+cmake -G Ninja -D CMAKE_BUILD_TYPE=Release \
+               -D LD_BUILD_REDIS_SUPPORT="$build_redis" \
+               -D BUILD_TESTING=OFF \
+               -D LD_BUILD_SHARED_LIBS=ON \
+               -D LD_DYNAMIC_LINK_BOOST=OFF \
+               -D CMAKE_INSTALL_PREFIX=./release ..
+
+cmake --build . --target "$1"
+cmake --install .
+cd ..
+
+# Build a static debug release.
+mkdir -p build-static-debug && cd build-static-debug
+mkdir -p release
+cmake -G Ninja -D CMAKE_BUILD_TYPE=Debug \
+               -D BUILD_TESTING=OFF \
+               -D LD_BUILD_REDIS_SUPPORT="$build_redis" \
+               -D CMAKE_INSTALL_PREFIX=./release ..
+
+cmake --build . --target "$1"
+cmake --install .
+
+cd ..
+
+# Build a dynamic debug release.
+mkdir -p build-dynamic-debug && cd build-dynamic-debug
+mkdir -p release
+cmake -G Ninja -D CMAKE_BUILD_TYPE=Debug \
+               -D BUILD_TESTING=OFF \
+               -D LD_BUILD_REDIS_SUPPORT="$build_redis" \
+               -D LD_BUILD_SHARED_LIBS=ON \
+               -D LD_DYNAMIC_LINK_BOOST=OFF \
+               -D CMAKE_INSTALL_PREFIX=./release ..
+
+cmake --build . --target "$1"
+cmake --install .