rename skip-verify-peer in the sse lib

Author: cwaldren-ld

libs/client-sdk/src/data_sources/polling_data_source.cpp

@@ -90,7 +90,7 @@ PollingDataSource::PollingDataSource(
         data_source_config.method);
     if (http_properties.Tls().VerifyMode() ==
         config::shared::built::TlsOptions::VerifyMode::kVerifyNone) {
-        LD_LOG(logger_, LogLevel::kDebug) << "SSL peer verification disabled";
+        LD_LOG(logger_, LogLevel::kDebug) << "TLS peer verification disabled";
     }
     if (polling_interval_ < polling_config.min_polling_interval) {
         LD_LOG(logger_, LogLevel::kWarn)

libs/client-sdk/src/data_sources/streaming_data_source.cpp

@@ -127,10 +127,11 @@ void StreamingDataSource::Start() {
         client_builder.header(header.first, header.second);
     }
 
-    client_builder.verify_peer(
-        http_config_.Tls().VerifyMode() ==
-        config::shared::built::TlsOptions::VerifyMode::kVerifyPeer);
-
+    if (http_config_.Tls().VerifyMode() ==
+        config::shared::built::TlsOptions::VerifyMode::kVerifyNone) {
+        client_builder.skip_verify_peer(true);
+    }
+    
     auto weak_self = weak_from_this();
 
     client_builder.receiver([weak_self](launchdarkly::sse::Event const& event) {

libs/server-sent-events/include/launchdarkly/sse/client.hpp

@@ -137,7 +137,7 @@ class Builder {
      * @param verify_peer True to verify the peer, false otherwise.
      * @return Reference to this builder.
      */
-    Builder& verify_peer(bool verify_peer);
+    Builder& skip_verify_peer(bool skip_verify_peer);
 
     /**
      * Builds a Client. The shared pointer is necessary to extend the lifetime
@@ -158,7 +158,7 @@ class Builder {
     LogCallback logging_cb_;
     EventReceiver receiver_;
     ErrorCallback error_cb_;
-    bool verify_peer_;
+    bool skip_verify_peer_;
 };
 
 /**

libs/server-sent-events/src/client.cpp

@@ -504,7 +504,7 @@ Builder::Builder(net::any_io_executor ctx, std::string url)
       logging_cb_([](auto msg) {}),
       receiver_([](launchdarkly::sse::Event const&) {}),
       error_cb_([](auto err) {}),
-      verify_peer_(true) {
+      skip_verify_peer_(false) {
     request_.version(11);
     request_.set(http::field::user_agent, kDefaultUserAgent);
     request_.method(http::verb::get);
@@ -562,8 +562,8 @@ Builder& Builder::errors(ErrorCallback callback) {
     return *this;
 }
 
-Builder& Builder::verify_peer(bool verify_peer) {
-    verify_peer_ = verify_peer;
+Builder& Builder::skip_verify_peer(bool skip_verify_peer) {
+    skip_verify_peer_ = skip_verify_peer;
     return *this;
 }
 
@@ -613,9 +613,9 @@ std::shared_ptr<Client> Builder::build() {
     if (uri_components->scheme_id() == boost::urls::scheme::https) {
         ssl = launchdarkly::foxy::make_ssl_ctx(ssl::context::tlsv12_client);
         ssl->set_default_verify_paths();
-        if (!verify_peer_) {
+        if (skip_verify_peer_) {
             ssl->set_verify_mode(ssl::context::verify_none);
-            logging_cb_("SSL peer verification disabled");
+            logging_cb_("TLS peer verification disabled");
         }
     }