feat: add StartAsync #110
Merged
feat: add StartAsync #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
May 23, 2023
kinyoklion
reviewed
May 23, 2023
libs/client-sdk/include/launchdarkly/client_side/bindings/c/sdk.h
Outdated
Show resolved
Hide resolved
kinyoklion
reviewed
May 23, 2023
kinyoklion
reviewed
May 24, 2023
kinyoklion
reviewed
May 24, 2023
cwaldren-ld
force-pushed
the
cw/fix-event-tests
branch
from
71dc021 to
05b3d44
Compare
kinyoklion
requested changes
May 24, 2023
kinyoklion
approved these changes
May 24, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
StartAsync, which allows users to wait on initialization using a future. It pulls initialization out of the constructor.