feat: foundation of an event processor #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #194283: Implement common Event processor. |
cwaldren-ld
force-pushed
the
cw/sc-194283/event-processor
branch
from
36d3700 to
431c519
Compare
This was referenced May 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the architecture of an event processor that can be extended to work with both client and server SDKs.
I figure this is a good stopping point for a PR, even though it isn't fully functional - mostly because the size is becoming unwieldy.
What's not implemented:
There is much to improve upon. The existing (few) tests are more like basic sanity checks just to ensure the components work together - I'd like to have some better ones, but also rely on the contract tests.