feat: Implement streaming data source. #17
Conversation
…unchdarkly/cpp-sdks-private into rlamb/implement-streaming-data-source
libs/client-sdk/include/launchdarkly/client_side/data_source_update_sink.hpp
Outdated
Show resolved
Hide resolved
| uint64_t version; | ||
| }; | ||
|
|
||
| StreamingDataHandler(std::shared_ptr<IDataSourceUpdateSink> handler, |
There was a problem hiding this comment.
nit: could be good to explain why the sink is shared ownership on the constructor
There was a problem hiding this comment.
I am not 100% sure what this will actually be. Currently I have a shared pointer to the handler type. But we have not made a data store, so I am not completely sure where the lifetimes of these will be managed. It may just change to a pointer.
There was a problem hiding this comment.
| Logger const& logger_; | ||
| std::shared_ptr<launchdarkly::sse::Client> client_; | ||
|
|
||
| inline static const std::string streaming_path_ = "/meval"; |
There was a problem hiding this comment.
Not sure if this is in the next PR, but this could be extracted into Defaults for the client SDK
There was a problem hiding this comment.
I had not considered putting the paths in the defaults.
There was a problem hiding this comment.
The whole process of making a streaming URL is different. So I am not sure on this yet.
There was a problem hiding this comment.
Co-authored-by: Casey Waldren <[email protected]>
No description provided.