fix: catch exception if en_US.utf8-locale missing when parsing datetime headers #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #217926: Missing locale causes unhandled exception in ParseDateTime. |
cwaldren-ld
force-pushed
the
cw/sc-217926/date-time-crash
branch
from
e72e001 to
86c92c5
Compare
cwaldren-ld
commented
Sep 20, 2023
| @@ -24,8 +24,6 @@ namespace launchdarkly::events { | |||
| */ | |||
| class WorkerPool { | |||
| public: | |||
| using ServerTimeCallback = | |||
| std::function<void(std::chrono::system_clock::time_point)>; | |||
| /** | |||
cwaldren-ld
force-pushed
the
cw/sc-217926/date-time-crash
branch
4 times, most recently
from
cd9e504 to
fdb6a25
Compare
cwaldren-ld
changed the title
kinyoklion
approved these changes
Sep 21, 2023
|
Well this is odd. With no changes to CI, apparently the windows build can't find OpenSSL. Looking into it. |
cwaldren-ld
force-pushed
the
cw/sc-217926/date-time-crash
branch
from
9c49f06 to
3a26c8c
Compare
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Sep 21, 2023
🤖 I have created a release *beep* *boop*
---
<details><summary>launchdarkly-cpp-client: 3.0.9</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* launchdarkly-cpp-internal bumped from 0.1.9 to 0.1.10
</details>
<details><summary>launchdarkly-cpp-internal: 0.1.10</summary>
##
[0.1.10](launchdarkly-cpp-internal-v0.1.9...launchdarkly-cpp-internal-v0.1.10)
(2023-09-21)
### Bug Fixes
* catch exception if en_US.utf8-locale missing when parsing datetime
headers ([#251](#251))
([eb2a8f0](eb2a8f0))
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event delivery subsystem inspects the HTTP headers on the event endpoints whenever it posts a batch of events.
It parses out the date header, storing it for later use. When emitting debug events, it is used to ensure that events stop emitting even if the host's time is off - as a form of time synchronization.
The parsing code is quite ugly, and also wrong - it assumed that
en_US.utf-8would always be available.This commit hoists the locale loading routine out of the individual flush-workers and into the worker pool. If it can't load the locale, it emits a single
warnlog at startup explaining the effect.