Adaptivity improvements #4184
Open
Adaptivity improvements #4184
+322
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lindsayad
force-pushed
the
sc-with-adaptivity
branch
from
1db4795 to
b57a129
Compare
lindsayad
changed the title
lindsayad
commented
Jun 11, 2025
lindsayad
force-pushed
the
sc-with-adaptivity
branch
from
458dc7b to
e9bb873
Compare
lindsayad
force-pushed
the
sc-with-adaptivity
branch
from
e9bb873 to
c4e48be
Compare
|
MetaPhysicL failure again 😦 |
lindsayad
force-pushed
the
sc-with-adaptivity
branch
from
3d07782 to
24e132a
Compare
This ensures that if there is no mesh refinement before another call to project vectors that vector projection will work Refs attempt to `disable_refine_in_reinit` in idaholab/moose#30742
lindsayad
changed the title
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Jun 12, 2025
lindsayad
added a commit
to lindsayad/moose
that referenced
this pull request
Jun 12, 2025
Because we do not use the SC dof map in any way for solution projection. And static condensation doesn't even make much sense without matrices
roystgnr
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
I think I'm happy with this, though I'd love for @jwpeterson to take a look too.
| @@ -166,6 +189,32 @@ class StaticCondensationDofMap : public DofMapBase | |||
|
|
|||
| /// Number of off-diagonal nonzeros per row in the reduced system | |||
| std::vector<dof_id_type> _reduced_noz; | |||
|
|
|||
| /// Set of local uncondensed degrees of freedom (numbered in the full system). This data member is | |||
| /// used only during the reinit phase and is cleared at its conclusion | |||
There was a problem hiding this comment.
It looks like you're also using it in the constructor, but in each case wouldn't it make sense to have this be a local variable rather than a member variable? You'd need to pass it to add_uncondensed_dof() as another argument, but then it's a little easier to follow program flow.
| std::unordered_map<processor_id_type, std::unordered_set<dof_id_type>> _nonlocal_uncondensed_dofs; | ||
|
|
||
| /// Used for temporary storage of uncondensed degrees of freedom active on an element | ||
| std::vector<dof_id_type> _elem_uncondensed_dofs; |
There was a problem hiding this comment.
Likewise for these two. Though I admit we're now up to three more arguments, and my suggestion is getting less compelling, it just feels confusing to have temporary storage saved as members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call to project vectors that vector projection will work. Refs [WIP] Don't do unnecessary refine in reinit idaholab/moose#30742