More remote rename fixes #2407
Merged
More remote rename fixes #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't allow renames of anonymous remotes, so there's no need to handle them. A remote is always associated with a repository, so there's no need to check for that.
We must make sure that the name pointer remains valid, so make sure to allocate the new one before freeing the old one and swap them so the user never sees an invalid pointer.
|
Hold off on this for a bit, I forgot that we also fail to retarget symrefs. |
|
Really like this callback removal. I really don't wanna put pressure on you, but I promised @arrbee I'd tag a release candidate this weekend, so if you could wrap this up, it'd be niiiiice. :p |
There is no reason why we need to use a callback here. A string array fits better with the usage, as this is not an event and we don't need anything from the user.
A symref inside the namespace gets renamed, we should make it point to the target's new name. This is for the origin/HEAD -> origin/master type of situations.
|
This should be it as far as rename stuff goes. I'd also like to fix the remote-freeing we do on remove. Would you prefer a different pr for that or should I just push it here? |
This was a bad idea. Don't free except in the free function.
|
PUSH. IT. HERE. 😉 |
|
Yeah, I just went ahead and did that. |
Move fast and break |
|
We've never made a release with remote deletion, so this is one place where I didn't break it ;) |
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
More remote rename fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a bunch of code and conditionals we just don't need and return the problems to the user as a list of strings instead of using a callback, which has no business being there.
From the discussion in libgit2/libgit2sharp#741