Protect TagAnnotation creation from name or message containing '\0'

Author: nulltoken

LibGit2Sharp.Tests/ObjectDatabaseFixture.cs

@@ -433,5 +433,22 @@ public void CreatingACommitWithMessageContainingZeroByteThrows(string message)
                     message, Constants.Signature, Constants.Signature, repo.Head.Tip.Tree, Enumerable.Empty<Commit>()));
             }
         }
+
+        [Theory]
+        [InlineData("\0Leading zero")]
+        [InlineData("Trailing zero\0")]
+        [InlineData("Zero \0inside")]
+        [InlineData("\0")]
+        [InlineData("\0\0\0")]
+        public void CreatingATagAnnotationWithNameOrMessageContainingZeroByteThrows(string input)
+        {
+            using (var repo = new Repository(BareTestRepoPath))
+            {
+                Assert.Throws<ArgumentException>(() => repo.ObjectDatabase.CreateTagAnnotation(
+                    input, repo.Head.Tip, Constants.Signature, "message"));
+                Assert.Throws<ArgumentException>(() => repo.ObjectDatabase.CreateTagAnnotation(
+                    "name", repo.Head.Tip, Constants.Signature, input));
+            }
+        }
     }
 }

LibGit2Sharp/ObjectDatabase.cs

@@ -222,6 +222,9 @@ internal Commit CreateCommit(string message, Signature author, Signature committ
         /// <returns>The created <see cref="TagAnnotation"/>.</returns>
         public virtual TagAnnotation CreateTagAnnotation(string name, GitObject target, Signature tagger, string message)
         {
+            Ensure.ArgumentDoesNotContainZeroByte(name, "name");
+            Ensure.ArgumentDoesNotContainZeroByte(message, "message");
+
             string prettifiedMessage = Proxy.git_message_prettify(message);
 
             ObjectId tagId = Proxy.git_tag_annotation_create(repo.Handle, name, target, tagger, prettifiedMessage);