Refactor Network Internal API #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty neat to me. @jamill ? |
|
|
||
| RemoteSafeHandle remoteHandle; | ||
|
|
||
| remoteHandle = Proxy.git_remote_create_anonymous(repoHandle, url); |
There was a problem hiding this comment.
any reason to not just initialize the remoteHandle to this value when declaring it? Not big deal either way...
|
Looks good to me - left just 2 small comments that are more style oriented. Thanks @whoisj! |
|
Both fair. I'll update in the morning. Thanks |
|
@jamill just pushed the changes you asked for. Let me know if this is ready, thanks. |
|
Looks like a random failure in AppVeyor. I'll "touch" a commit and restart it. |
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <configuration> | |||
There was a problem hiding this comment.
@whoisj You may have unintentionally staged too many files....
added 2 commits
June 10, 2015 09:59
…itancy updated caller methods as necissary
nulltoken
added a commit
that referenced
this pull request
Jun 10, 2015
Refactor Network Internal API
|
👍 I'm eager to see the new Coverity numbers!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084
DoFetchinto three overloaded methods.RemoteSafeHandleRemote, acquires aRemoteSafeHandle, and calls primaryRemoteSafeHandle, and calls primary